When to sell depends on your financial goal, not on what the stock price does

The most common mistake is selling because the price went up or down. Stock prices move every day for reasons that have nothing to do with whether you should own that stock. A better approach is to sell when one of these things happens: you need the money for something specific, the reason you bought the stock no longer exists, you want to rebalance your portfolio back to your target mix, or you have held it long enough that taxes on the gain matter less than the money you need now.

Selling is not about timing the market perfectly. It is about matching what you own to what you are trying to accomplish. This guide explains the real situations when selling makes sense, and the ones where holding usually costs you less in taxes and trading costs.

Key Takeaways

  • Sell a stock when you need the money for a planned expense, not because you think the price will drop further.
  • If the company fundamentals changed — the business model broke, management left, or the industry shifted — that is a reason to reconsider holding.
  • Selling to rebalance your portfolio (bringing it back to your target allocation) is one of the few times selling for strategy reasons makes sense.
  • Holding for more than one year usually means lower tax rates on your gain, so tax timing matters when you are deciding whether to sell now or later.
  • Selling at a loss to offset gains elsewhere in your portfolio (tax-loss harvesting) can reduce what you owe, but you cannot buy the same stock back for 30 days.

You need the money for something specific

This is the clearest reason to sell. If you are saving for a down payment, paying for education, covering medical bills, or funding a major life change in the next one to three years, you should not hold that money in stocks at all — you should move it to a savings account or money market fund where it will not lose value right when you need it.

If you already hold stocks and you now need that money, sell enough to cover what you need. Sell the positions with the smallest gains first (or losses, if you have them) to keep your tax bill as low as possible. If you have held the stock for less than a year, the gain counts as short-term capital gains and is taxed at your ordinary income rate, which is usually higher. If you have held it for more than a year, it is taxed at the long-term capital gains rate, which is lower for most people.

The reason you bought the stock no longer exists

You bought a stock because you believed something about the company — that it had a competitive advantage, that management was strong, that the industry was growing, or that the price was cheap relative to earnings. If that belief changes, holding becomes a different bet than the one you made.

Examples: the company's main product is now obsolete; the CEO who built the business left and the replacement has a different strategy; a competitor released something that makes this company's offering irrelevant; the regulatory environment changed and now the business model does not work; or the financial statements show the company is burning cash faster than expected. In these cases, the stock price may not have moved yet, but the underlying reason to own it is gone. Waiting for the price to recover is hoping the market is wrong, not investing based on facts.

This is different from a stock being down 20 percent. A down price alone is not a reason to sell. A change in the business is.

Your portfolio is out of balance with your target allocation

If you decided to hold 60 percent stocks and 40 percent bonds, but a big stock gain means you now hold 70 percent stocks, you are taking more risk than you planned. Rebalancing means selling some of the stocks that have grown and moving the money into bonds (or whatever your target is). This forces you to sell high and buy low, which is the opposite of what most people do.

Rebalancing also serves a practical purpose: it keeps your portfolio aligned with your risk tolerance. If you cannot sleep at night because you are holding too much in stocks, rebalancing back to your target mix is not a market-timing move — it is a sanity move.

How often to rebalance depends on how strict you want to be. Some people rebalance once a year; others rebalance only when the allocation drifts more than 5 percentage points from the target. The exact schedule matters less than actually doing it, because rebalancing is one of the few times selling for strategy reasons has been shown to improve long-term returns.

You have held the stock long enough that tax timing matters

If you bought a stock six months ago and it is up 30 percent, selling now means paying short-term capital gains tax on that 30 percent gain. If you wait six more months, the same gain is taxed at the long-term rate, which is usually 15 percent instead of your marginal income tax rate (which could be 22, 24, 32 percent or higher depending on your income).

The math is simple: if the tax savings are larger than the risk of the stock falling in the next six months, waiting makes sense. If you are nervous about the stock and think it might drop, the tax savings may not be worth the risk. But if you are comfortable holding it, the tax difference is real money.

This logic flips if you have a loss. If you bought a stock at $100 and it is now $70, you can sell it, claim the $30 loss against other gains, and reduce your tax bill. But you cannot buy the same stock (or a substantially identical one) back for 30 days — that is the wash-sale rule. If you think the stock will recover and you want to own it again, you have to wait the 30 days or buy a different stock in the same sector in the meantime.

You are rebalancing between different account types

If you hold the same stock in both a taxable account and a retirement account (401k, IRA), selling in the retirement account has no tax consequence. Selling in the taxable account does. When you need to rebalance or raise cash, sell from the retirement account first. This keeps your taxable account more stable and lets you defer the tax hit.

Similarly, if you have a large gain in a taxable account and a loss in another taxable account, you can sell the loser to offset the winner's gain. This is tax-loss harvesting, and it is one of the few times selling for tax reasons actually improves your after-tax return.

You should not sell just because the price dropped

A stock falling 20 or 30 percent is not a reason to sell unless something about the company changed. If you bought it because you believed in the business, and nothing about the business has changed, the lower price is actually an opportunity to buy more (if you have cash) or to hold and wait for the price to recover. Selling after a drop locks in the loss and means you miss the recovery.

This is called panic selling, and it is one of the most expensive mistakes investors make. The urge to sell when a stock is down is strong, but it usually leads to selling low and buying back in high. If you find yourself wanting to sell because you are uncomfortable with the volatility, that is a sign you should have held less in stocks to begin with — not that you should sell at the worst time.

Frequently Asked Questions

Should I sell a stock that has gone up a lot?

Not automatically. A big gain is not a reason to sell unless you need the money, the company fundamentals changed, or your portfolio is out of balance. If you still believe in the company and you are comfortable with the risk, holding can make sense. The longer you hold, the more of the gain is taxed at the lower long-term rate.

What if I think the stock price will keep falling?

If you think the price will fall because the business is deteriorating, sell. If you think it will fall because the market is being irrational and you still believe in the company, holding usually costs you less than selling and buying back in. Most people who try to time the market by selling before a drop end up selling low and buying back high.

Is it better to sell all at once or gradually?

If you need the money now, sell what you need now. If you are selling because the stock is overvalued or you want to rebalance, selling gradually over a few weeks or months can reduce the risk that you sell everything right before a big jump. But the tax and trading cost difference is usually small — the bigger mistake is waiting too long to sell when you should have already.

Do I have to sell a stock that is losing money?

No. Holding a losing stock is not a mistake unless the business has broken. But if you have other gains elsewhere in your portfolio, selling the loser to offset those gains can reduce your tax bill. You just cannot buy it back for 30 days.

What happens to dividends if I sell?

If you sell before the ex-dividend date (the date the company sets for who gets the next dividend), you do not receive that dividend. If you sell after, you do. Check the ex-dividend date before you sell if the upcoming dividend matters to your decision.